JclIDEUtils: fix memory leaks in ReadInstallations#170
Merged
obones merged 1 commit intoproject-jedi:masterfrom Mar 23, 2026
Merged
JclIDEUtils: fix memory leaks in ReadInstallations#170obones merged 1 commit intoproject-jedi:masterfrom
obones merged 1 commit intoproject-jedi:masterfrom
Conversation
Member
|
Thanks for this. I'd really prefer if |
Delphier
force-pushed
the
memoryleaks-readinstallations
branch
from
6892943 to
1b9a8b9
Compare
Contributor
Author
|
@obones Hello, |
obones
reviewed
Jan 21, 2026
jcl/source/common/JclIDEUtils.pas
Outdated
| Result := True; | ||
| end; | ||
| end | ||
| AddInstallation(CreateClass, VersionKeyName) |
Member
There was a problem hiding this comment.
If the else part has a begin/end pair, the style guide mandates that the if part has as well. Could you please make sure this is the case?
Contributor
Author
There was a problem hiding this comment.
Hello, added begin/end pair.
Delphier
force-pushed
the
memoryleaks-readinstallations
branch
from
1b9a8b9 to
939c6d7
Compare
Contributor
Author
|
@obones Hi, any updates on this PR? Let me know if there's anything I can do to help get it merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.